Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Binds Xp projector, refactors binding utils to make them reusable when running locally in dev mode #10190

Merged
merged 6 commits into from
Dec 10, 2024
Merged

Binds Xp projector, refactors binding utils to make them reusable when running locally in dev mode #10190

merged 6 commits into from
Dec 10, 2024

Conversation

Rotorsoft
Copy link
Contributor

Link to Issue

Closes: #10188

Description of Changes

  • Creates Xp bindings
  • Refactors policies in commonwealth to libs/model/policies
  • Refactors binding utils in commonwealth/server/bindings
  • Uses new binding utils in consumer and relayer workers
  • Uses new binding utils in server when in dev mode (no need to run consumer and relayer when testing locally)

Test Plan

  • Make sure you can test your flows locally, in this case creating a thread or comment will relay those events to the Xp projector

@Rotorsoft Rotorsoft requested a review from rbennettcw December 9, 2024 20:53
timolegros
timolegros requested changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@timolegros timolegros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 quick comments

Can you deploy this to Frack or Frick and verify everything is ok?

libs/adapters/src/rabbitmq/types.ts Outdated Show resolved Hide resolved
packages/commonwealth/server.ts Show resolved Hide resolved
@Rotorsoft Rotorsoft requested a review from timolegros December 10, 2024 15:26
@Rotorsoft
Copy link
Contributor Author

Tested on Frick

@Rotorsoft Rotorsoft merged commit 45780d8 into master Dec 10, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbennettcw rbennettcw rbennettcw approved these changes

@timolegros timolegros timolegros approved these changes

@kurtisassad kurtisassad Awaiting requested review from kurtisassad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bind Xp projector
3 participants
@Rotorsoft @timolegros @rbennettcw