From 7dd9196724eebc2c6a14d1e37848322e418e04e4 Mon Sep 17 00:00:00 2001 From: Jake Naviasky Date: Wed, 7 Aug 2024 13:54:46 -0400 Subject: [PATCH] Remove TODO comments. --- libs/model/src/community/GetCommunities.query.ts | 1 - libs/schemas/src/queries/community.schemas.ts | 5 ++++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/libs/model/src/community/GetCommunities.query.ts b/libs/model/src/community/GetCommunities.query.ts index b38c7aa14bd..e3f8e6c7349 100644 --- a/libs/model/src/community/GetCommunities.query.ts +++ b/libs/model/src/community/GetCommunities.query.ts @@ -10,7 +10,6 @@ export function GetCommunities(): Query { auth: [], secure: false, body: async ({ payload }) => { - // TODO: constrain order_by const { base, tag_ids, diff --git a/libs/schemas/src/queries/community.schemas.ts b/libs/schemas/src/queries/community.schemas.ts index 63035f71950..9dcba656a53 100644 --- a/libs/schemas/src/queries/community.schemas.ts +++ b/libs/schemas/src/queries/community.schemas.ts @@ -11,7 +11,10 @@ import { PaginatedResultSchema, PaginationParamsSchema } from './pagination'; export const GetCommunities = { input: PaginationParamsSchema.extend({ base: z.nativeEnum(ChainBase).optional(), - // TODO: why is this a type error? + // NOTE 8/7/24: passing arrays as GET requests is not supported + // to support this field, we converted queries to use POST instead + // but we may need a workaround such as a regex-parsed string + // in the future, depending on the impact of the GET-POST change. tag_ids: PG_INT.array().optional(), include_node_info: z.boolean().optional(), stake_enabled: z.boolean().optional(),