Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for ruby-2.4 #137

Open
thomst opened this issue May 4, 2020 · 2 comments
Open

Support for ruby-2.4 #137

thomst opened this issue May 4, 2020 · 2 comments
Labels
wontfix This will stay as is for now.

Comments

@thomst
Copy link

thomst commented May 4, 2020

The README declares ruby support for

Ruby 2.0.0 - 2.3.x

We use hourglass in version 1.1.1 with ruby 2.4.6-p354 for quiet a while and it is working fine.
Did you consider to officially support ruby 2.4 ?

@arBmind
Copy link
Member

arBmind commented May 5, 2020

Hi @thomst,
I am happy to read that it works fine for you.
It seems we planned to skip Ruby 2.4 and jump to Ruby 2.5 / 2.6 directly.
Right now this gives us build errors, I hope someone will investigate them soon.

@thomst
Copy link
Author

thomst commented May 11, 2020

Hi @arBmind.
Thanks for the feedback. Yes, it makes totally sense to skip 2.4. Unfortunately we stick to ruby-2.4 because of compatibility-issues of other plugins. I also remember that we once tried to update hourglass to 1.1.2 and had some minor issues. But I can't say if it was because of the ruby-version. Nevertheless thanks for the plugin. It is a great support for our company.

@arBmind arBmind added the wontfix This will stay as is for now. label Jan 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will stay as is for now.
Projects
None yet
Development

No branches or pull requests

2 participants