[DRAFT] Implement Dot Product Similarity Distance algorithm #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Overall Observation from the benchmark:
Current results of Benchmark test: |
hicder
reviewed
Nov 17, 2024
Comment on lines
+40
to
+45
| while i + step <= a.len() { | ||
| let a_slice = f32x8::from_slice(&a[i..]); | ||
| let b_slice = f32x8::from_slice(&b[i..]); | ||
| self.dist_simd_8 += a_slice * b_slice; | ||
| i += step; | ||
| } |
There was a problem hiding this comment.
Suggested change
| while i + step <= a.len() { | |
| let a_slice = f32x8::from_slice(&a[i..]); | |
| let b_slice = f32x8::from_slice(&b[i..]); | |
| self.dist_simd_8 += a_slice * b_slice; | |
| i += step; | |
| } | |
| while i + 16 <= a.len() && i + 16 < b.len(){ | |
| let a_slice = f32x16::from_slice(&a[i..i + 16]); | |
| let b_slice = f32x16::from_slice(&b[i..i + 16]); | |
| self.dist_simd_16 += a_slice * b_slice; | |
| i += step; | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this change?
What changes have been made?
dot_product_similarity.rsso far has the implementation of Scalar and SIMD typeCreating this draft PR for first round review - there is definitely room for improvements so would appreciate any inputs/feedbacks you can give, thanks so much!