Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Dot product Similarity #86

Open
Taenerys opened this issue Nov 9, 2024 · 1 comment · May be fixed by #120
Open

Add support for Dot product Similarity #86

Taenerys opened this issue Nov 9, 2024 · 1 comment · May be fixed by #120
Labels
good first issue Good for newcomers

Comments

@Taenerys
Copy link

Taenerys commented Nov 9, 2024

Context: Currently we have only implemented Euclidean Distance (L2 norm) (can read more about it from l2.rs file in Utils module)

As a starting point to get familiar with the codebase, we want to implement Dot product Similarity. Resources:
https://www.pinecone.io/learn/vector-similarity/
https://tivadardanka.com/blog/how-the-dot-product-measures-similarity

Acceptance:

  • Add unit tests
  • Add benchmark tests
@Taenerys Taenerys self-assigned this Nov 9, 2024
@Taenerys
Copy link
Author

For my personal learning and research:

@hicder hicder added the good first issue Good for newcomers label Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants