HHH-18867 correctly implement the documented semantics of beginTransaction() #9287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and clarify its semantics in the jdoc
…PA method The JPA spec does not have anything to say about our beginTransaction() method
gavinking
changed the title
|
@sebersole WDYT? |
|
I dislike changing the semantics here yet again. We've changed the semantics around But I agree this does match better with the JPA spec, so +1 |
sebersole
approved these changes
Nov 21, 2024
| @@ -68,6 +68,17 @@ public interface SharedSessionContract extends QueryProducer, AutoCloseable, Ser | |||
| * Begin a unit of work and return the associated {@link Transaction} object. | |||
| * If a new underlying transaction is required, begin the transaction. Otherwise, | |||
| * continue the new work in the context of the existing underlying transaction. | |||
| * <p> | |||
| * The JPA-standard way to begin a new transaction is by calling | |||
There was a problem hiding this comment.
Since you are calling out JPA-specific expectations here, might also be worth noting here that JPA disallows this in JTA environments and we also honor that with strict compliance.
beikov
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and clarify its semantics in the jdoc
[Please describe here what your change is about]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.