Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DontReturnFromCloneLinter #546

Open
lexidor opened this issue Jun 14, 2023 · 0 comments
Open

DontReturnFromCloneLinter #546

lexidor opened this issue Jun 14, 2023 · 0 comments

Comments

@lexidor
Copy link
Contributor

lexidor commented Jun 14, 2023

For rationale, see facebook/hhvm#3757.

Returning a value from __clone() is always a mistake, since the return value is never used. __clone is called on the newly created object before resolving a clone $obj expression.

Checking the return type of the method ought to be enough. No need to actually check the body for returns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant