Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write tests for __Private\Resolution\resolve_function() #275

Open
lexidor opened this issue Mar 14, 2020 · 1 comment
Open

Write tests for __Private\Resolution\resolve_function() #275

lexidor opened this issue Mar 14, 2020 · 1 comment

Comments

@lexidor
Copy link
Contributor

lexidor commented Mar 14, 2020

I had to use it in DontUseAsioJoinLinter and there were 0 known usages.
There are no test cases either.
I figured out the API with some guess work.

The documentation I wrote might not be 100% accurate and it is better to demonstrate the functions capabilities using a couple of tests.
@jjergus
Copy link
Contributor

jjergus commented Mar 19, 2020

there were 0 known usages.

I think it's used from hh-apidoc, definition-finder, and/or user-documentation

But I agree, we should have tests too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jjergus @lexidor