Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: hhast-lint option to skip certain linters in as-you-type mode #244

Open
ssandler opened this issue Dec 4, 2019 · 3 comments

Comments

@ssandler
Copy link
Contributor

ssandler commented Dec 4, 2019

When linting in as-you-type mode with the LSP, performance is a huge concern, more so than it is in CLI mode where we may be executing the linter in a continuous integration environment. We'd like to be able to have certain lint rules only run in CLI mode, which we currently do by setting an environment variable and checking it in the lint rule code. Making this a hhast-lint setting could help separate these use cases.

@fredemmott
Copy link
Contributor

This could involve:

  • separate lists of defaults for as-you-type vs CLI
  • separate json config files for as-you-type vs CLI
  • interface markers on the linters to indicate if they're suitable for as-you-type
  • ... some combination of the above

@fredemmott
Copy link
Contributor

interface markers on the linters to indicate if they're suitable for as-you-type

@ssandler how well do you think this would work as a per-linter thing rather than per-project?

@ssandler
Copy link
Contributor Author

ssandler commented Dec 4, 2019

I think that would work quite well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants