Skip to content
This repository has been archived by the owner on May 6, 2021. It is now read-only.

Refactor source #5

Open
4 tasks
hhsnopek opened this issue May 28, 2015 · 6 comments
Open
4 tasks

Refactor source #5

hhsnopek opened this issue May 28, 2015 · 6 comments
Labels
Milestone

Comments

@hhsnopek
Copy link
Owner

The current source of PourOver is a bit messy and can be cleaned up. Possibly removing all dependencies in the process or just underscore.

  • snake_case to camelCase of all methods and variables.
  • Refactor into Prototypal OO
  • Change documentation to JSDoc3
  • Convert to ES6
@hhsnopek hhsnopek added this to the v2.0.0 milestone May 28, 2015
@TomNeyland
Copy link

I'd be interesting in exploring this a bit, I'll start idling in the gitter chat so we can talk it out.

@hhsnopek
Copy link
Owner Author

Awesome! I'm always idle in the channel - ping me when you can :D

@nichoth
Copy link

nichoth commented Sep 28, 2015

Cool. I would advocate refactoring into several commonjs files, replacing underscore with individual lodash.* dependencies, and using browserify to create a distributable version.

@hhsnopek
Copy link
Owner Author

@nichoth I'm actually going for es6 modules and splitting everything similarly but using folders just like moment.js

@nichoth
Copy link

nichoth commented Sep 29, 2015

Cool I haven't worked with es6 things yet

@hhsnopek
Copy link
Owner Author

the only thing from emca2015 that I'm taking is the import/export modules

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants