Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double-check localization code usage. ISO 639-1 #234

Open
gregjurman opened this issue Mar 24, 2015 · 1 comment
Open

Double-check localization code usage. ISO 639-1 #234

gregjurman opened this issue Mar 24, 2015 · 1 comment
Labels

Comments

@gregjurman
Copy link
Member

Double check if server is using the four letter language code(en-US, es-ES) or just the two(en, es). Much like The Queen's English (en-GB) verses 'murican (en-US), there are differences between the Spanish (es-ES, es-MX) languages as well.

Most systems will spit out a four letter code for i18n/L10n compliance as it is a user preference. The server should respect the four letter code, and only degrade to two if there is no direct match.

@thequbit
Copy link
Member

thequbit commented Nov 1, 2015

I think we'll just split on "-" and take the first part. That is how it is currently implemented. Will keep this open for discussion though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants