test pandas pre #237
Merged
test pandas pre #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mutricyl
reviewed
Jul 2, 2024
| pip install .[test] | ||
|
|
||
| - name: Install pandas | ||
| if: ${{ matrix.pandas != null }} |
There was a problem hiding this comment.
Suggested change
| if: ${{ matrix.pandas != null }} | |
| if: ${{ matrix.pandas != null }} | |
| pip uninstall pandas -y |
|
@andrewgsavage it look like this new CI job does not really install pandas nightly build: https://github.com/hgrecco/pint-pandas/pull/237/checks#step:10:9 you need to uninstalled previously installed version first as stated in pandas documentation |
dopplershift
reviewed
Jul 8, 2024
Comment on lines
+10
to
+12
| - Support for NumPy verson 2 | ||
| - Minimum Pint version is 0.24 | ||
| - Minimum Pandas version is 2.2 |
There was a problem hiding this comment.
These are not the versions currently specified in pyproject.toml:
Lines 25 to 30 in 0e6a5ac
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pre-commit run --all-fileswith no errors