Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slow rendering in comparison to landscape #57

Closed
iMilnb opened this issue Feb 26, 2016 · 3 comments
Closed

Slow rendering in comparison to landscape #57

iMilnb opened this issue Feb 26, 2016 · 3 comments

Comments

@iMilnb
Copy link
Contributor

iMilnb commented Feb 26, 2016

So there's this issue I opened at hexo github page hexojs/hexo#1769 and we figured out that the light makes the pages generation 15 times slower than the landscape theme with 400 posts. Would you have an idea on what makes the light theme so slow in comparison to generate?

Edit

It's the tagcloud widget that actually slows down every page generation.

@iMilnb
Copy link
Contributor Author

iMilnb commented Feb 27, 2016

Not really theme's fault,

@iMilnb iMilnb closed this as completed Feb 27, 2016
@iMilnb
Copy link
Contributor Author

iMilnb commented Feb 27, 2016

Turns out this issue can be fixed within the light theme by replacing:

<aside id="sidebar" class="alignright"><%- partial('_partial/sidebar') %></aside>

with

<aside id="sidebar" class="alignright"><%- partial('_partial/sidebar', {}, {cache: true}) %></aside>

in layout.ejs. Using fragment_cache makes the generation drop to a stunning 5s instead of 4mn.

@iMilnb iMilnb reopened this Feb 27, 2016
iMilnb added a commit to iMilnb/hexo-theme-light that referenced this issue Feb 27, 2016
@leesei
Copy link
Member

leesei commented Feb 28, 2016

Merged, thanks.

@leesei leesei closed this as completed Feb 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants