Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI is broken for community contributions #741

Open
stof opened this issue Jul 2, 2024 · 2 comments
Open

CI is broken for community contributions #741

stof opened this issue Jul 2, 2024 · 2 comments
Labels

Comments

@stof
Copy link
Contributor

stof commented Jul 2, 2024

the CI jobs seems to be relying on github secrets to be present. But those secrets are not exposed in pull_request jobs for untrusted PRs (i.e. PRs coming from forks) to avoid the risk of a malicious PR leaking the secret.
See https://github.com/heroku/heroku-buildpack-php/actions/runs/9665966313/job/26664478221?pr=738 for the result of such CI job.

This creates a confusing experience for contributors.

@dzuelke
Copy link
Contributor

dzuelke commented Jul 4, 2024

Right, but... what do you suggest we do about it? ;)

@dzuelke dzuelke added the support label Jul 4, 2024
@stof
Copy link
Contributor Author

stof commented Jul 5, 2024

Well, maybe those CI jobs requiring secrets should be skipped when secrets are not available instead of reporting weird failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants