From 10a35851da50c5c2771d037c8294f20128483b97 Mon Sep 17 00:00:00 2001 From: Ed Morley <501702+edmorley@users.noreply.github.com> Date: Thu, 1 Feb 2024 15:14:52 +0000 Subject: [PATCH 1/2] Reduce team review request noise from CODEOWNERS The `CODEOWNERS` file has been adjusted to request review from the primary repository maintainer for high-traffic files that are typically updated via automation, rather than requesting review from the whole team. This: - reduces team notification/review request noise for Dependabot and release automation PRs, given that other members on the team usually aren't going to look at such PRs anyway, and it only makes it harder for team members to see the review requests that are actually in their queue - retains the "team awareness" benefit of having the team see notifications for all other non-automated PRs - retains the UX benefit of having a reviewer be automatically selected In the scenarios where either the primary repository maintainer is away, or they are the person opening the PR (so can't request review from themselves), other team members will still be able to approve the PR with the changes I've made to the branch protection settings (unchecking "Require Code Owner Review", leaving "require approvals" enabled which can only be from teams with write access, which is only us. Plus for bonus points, the option to only permit merging from members of our team has also been enabled). For supported syntax, see: https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners GUS-W-14941625. --- .github/CODEOWNERS | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 25f6404..4268008 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -1 +1,5 @@ * @heroku/languages + +# Reduce team review request noise for Dependabot updates and automated release PRs. +CHANGELOG.md @Malax +Gemfile.lock @Malax From 43e5233180c616ac841f4d840aef92fe85fd6f87 Mon Sep 17 00:00:00 2001 From: Ed Morley <501702+edmorley@users.noreply.github.com> Date: Thu, 1 Feb 2024 16:28:45 +0000 Subject: [PATCH 2/2] Update explanation comments in CODEOWNERS --- .github/CODEOWNERS | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 4268008..78660b5 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -1,5 +1,7 @@ +# Default to requesting pull request reviews from the Heroku Languages team. * @heroku/languages -# Reduce team review request noise for Dependabot updates and automated release PRs. +# However, request review from the language owner instead for files that are updated +# by Dependabot or release automation, to reduce team review request noise. CHANGELOG.md @Malax Gemfile.lock @Malax