Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gracefully handle carriage return in package names #93

Closed
wants to merge 1 commit into from
Closed

Gracefully handle carriage return in package names #93

wants to merge 1 commit into from

Conversation

brandoncc
Copy link

Fixes #53

I don't know how to run a test suite on this, so I did some manual testing within a heroku/heroku:18 docker image. Here is that testing:

root@10d7dcaf938e:/# echo -e "This is line one\r\nThis is line two\r\nThis is line three" > test_broken_lines
root@10d7dcaf938e:/# cat test_broken_lines | grep -P '\r' | cat
This is line one
This is line two
root@10d7dcaf938e:/# cat test_broken_lines | sed -e 's/\r//g'
This is line one
This is line two
This is line three
root@10d7dcaf938e:/# cat test_broken_lines | sed -e 's/\r//g' | grep -P '\r' | cat
root@10d7dcaf938e:/#

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to locate package if Windows-style CR+LF newlines used in Aptfile
1 participant
@brandoncc