Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Printing method in response without validation #6

Open
YasserGersy opened this issue Aug 20, 2016 · 3 comments
Open

Printing method in response without validation #6

YasserGersy opened this issue Aug 20, 2016 · 3 comments

Comments

@YasserGersy
Copy link

when you request a page with non standard method like GETTTTT22 the server will respond with error method invalid and printing the value back , so we can inject html elements in method fields without spaces
and the server will print it back

@ferd
Copy link
Contributor

ferd commented Aug 21, 2016

Ah, I don't think that it would be a good idea to use cowboyku without vegur. Just use the standard cowboy then. cowboyku is a fork of cowboy with the explicit objective of not holding people back on a specific cowboy version.

This bug is ignored by vegur as a proxy since, well, it is a proxy.

@YasserGersy YasserGersy changed the title Method Injection Printing method in response without validation Aug 22, 2016
@YasserGersy
Copy link
Author

any link for a documentation ?

@ferd
Copy link
Contributor

ferd commented Aug 22, 2016

The README for vegur contains all relevant information for vegur.

This library's own README contains relevant information to the forking of cowboy (with my own emphasis added):

Cowboy is a small, fast and modular HTTP server written in Erlang. Cowboyku is a fork of that server used in conjunction with vegur, Heroku's HTTP proxy library.

It is functionally equivalent to Cowboy 0.10.0, with custom patches added in to function properly as a proxy's web server (Proxies and HTTP servers have slitghly varying specifications) and parser.

Cowboyku is not expected to be used standalone. It is rather a fork used so that both Cowboy and Vegur might be used from within the same virtual machine without holding users of Cowboy back. This allows Heroku to maintain a stable proxy, upgraded at a pace we judge adequate for the production applications on our platform, while any user of the proxy might develop interfaces and matching work on a newer Cowboy version as required.

There is no long-term guarantee this library will be used or maintained. Depending on developments in the Cowboy servers and Heroku's Routing team agenda, we might eventually just drop this fork and go back to mainline (or update it) without further notice.

If you're looking for a web server, you should just use cowboy directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants