Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use regular expressions for dependency inspection #500

Open
Malax opened this issue May 23, 2023 · 0 comments
Open

Don't use regular expressions for dependency inspection #500

Malax opened this issue May 23, 2023 · 0 comments

Comments

@Malax
Copy link
Member

Malax commented May 23, 2023

The Maven buildpack currently tries to detect the used framework by using regular expressions. This is a very naive approach that can fail with more complex project setups. Ideally, we'd execute Maven to get a resolved dependency tree (maybe via dependency:list) which we can parse and operate on later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant