Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove/activate dead legacy network code #454

Closed
jounathaen opened this issue Jan 4, 2023 · 1 comment
Closed

Remove/activate dead legacy network code #454

jounathaen opened this issue Jan 4, 2023 · 1 comment

Comments

@jounathaen
Copy link
Member

The code in https://github.com/hermitcore/uhyve/blob/master/src/linux/uhyve.rs#L41-L121 is never actually used.
Thus the hypercalls NETREAD|NETSTAT|NETWRITE are unnecessary.

As stated in #374, a new approach for network support is in the making, but that one will use virtio instead of hypercalls.
@jounathaen jounathaen mentioned this issue Jan 6, 2023
Merged
8 tasks
@jounathaen
Copy link
Member Author

Fixed in #519

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jounathaen