Skip to content
This repository has been archived by the owner on Aug 7, 2019. It is now read-only.

3 Characters Needed before Searching Works #23

Open
guyulmaz opened this issue Aug 14, 2017 · 5 comments
Open

3 Characters Needed before Searching Works #23

guyulmaz opened this issue Aug 14, 2017 · 5 comments
Labels

Comments

@guyulmaz
Copy link

No description provided.

@hergaiety
Copy link
Owner

@guyulmaz not able to reproduce this on the web or android versions. Please include more details on what and where the problem is so that I may look into it.

@guyulmaz
Copy link
Author

[url=https://hizliresim.com/N1j4Mk][img]https://i.hizliresim.com/N1j4Mk.png[/img][/url]

Search not filter when I type chars and press enter

@guyulmaz
Copy link
Author

I have seen filter start to work after 3 chars, so it is ok

@hergaiety
Copy link
Owner

@guyulmaz you're right, I'll look into making the user experience around that better or removing the minimum character limit altogether.

@hergaiety
Copy link
Owner

json-query-chain dependency no longer has arbitrary 3 character first limitation.

Should consider if a character limit should exist within My Spells though for performance and useful search considerations. Also will not close out this ticket until the latest json-query-chain is used and planned to be released into a new app version.

@hergaiety hergaiety added the bug label Oct 3, 2017
@hergaiety hergaiety changed the title Search not working 3 Characters Needed before Searching Works Oct 3, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants