Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new flag create-symlink #172

Merged
merged 1 commit into from
Dec 22, 2023
Merged

Add a new flag create-symlink #172

merged 1 commit into from
Dec 22, 2023

Conversation

UNIDY2002
Copy link
Contributor

It is an optional flag, so it should not break existing usages.

Why this PR work?

References:

These links above all point out that we can use a symlink to let ccache override the default compilers.

@hendrikmuhs
Copy link
Owner

Nice addition, thanks for your contribution!

@hendrikmuhs hendrikmuhs merged commit 2a51777 into hendrikmuhs:main Dec 22, 2023
41 checks passed
@anr2me
Copy link

anr2me commented Dec 23, 2023

Btw, should i ignored this warning from github's action/workflow? will create-symlink still work?

Warning: Unexpected input(s) 'create-symlink', valid inputs are ['key', 'restore-keys', 'max-size', 'verbose', 'variant', 'save', 'append-timestamp']

@UNIDY2002
Copy link
Contributor Author

@anr2me Sorry for the confusion in documentation. I think we should directly use the action from main, like here. Would you check whether the warning disappears after using the action directly from main?

@hendrikmuhs Sorry for the mistake in documentation. Would you mind updating the documentation of this repository to fix it up? Thanks :)

uses: hendrikmuhs/[email protected]

@anr2me
Copy link

anr2me commented Dec 23, 2023

Yes, the warning disappear when using main, thanks

@hendrikmuhs
Copy link
Owner

@hendrikmuhs Sorry for the mistake in documentation. Would you mind updating the documentation of this repository to fix it up? Thanks :)

I've created a new release and updated the tags, the instructions should work from now on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants