diff --git a/docs/MIDIThingV2.md b/docs/MIDIThingV2.md index dd4b05f..b61132e 100644 --- a/docs/MIDIThingV2.md +++ b/docs/MIDIThingV2.md @@ -17,3 +17,12 @@ To use, first ensure the MIDI Thing v2 is plugged into your computer, and visibl To use, simply wire CV which you wish to send to the hardware to the matching input on the VCV module. Note that you will need to select the range, which can be done by right-clicking on the matching box (see below). Options are 0/10v, -5/5v, -10/0v, 0/8v, 0/5v. Note that the module is **not** designed to work with audio rate signals, just CV. ![MIDI Thing Voltage Range](img/VoltageRange.png "MIDI Thing v2 Voltage Range") + +## Update Rate + +Midi Thing v2 VCV allows the user to configure the update rate at which data is sent over MIDI. This must be shared between the channels, so if we set the hardware to update at 1 kHz, 1 active channel will update at 1 kHz, 2 active channels will update at 500 Hz, 4 active channels at 250 Hz and so on. The total update rate (to be shared between channels) is set from the context menu, noting that higher update rates will use more CPU. The effect of the update rate on a 90 Hz saw (blue trace) can be seen in the bottom image, specifically that the temporal resolution of the reconstructed signal (red traces) improves as the update rate is increased from 500 Hz to 1000 Hz to 2000 Hz. + +![MIDI Thing Update Rates](img/UpdateRate.png "MIDI Thing v2 Update Ranges Menu") +![MIDI Thing Update Rates](img/UpdateRatesScope.png "MIDI Thing v2 Update Ranges Menu") + + diff --git a/docs/img/UpdateRate.png b/docs/img/UpdateRate.png new file mode 100644 index 0000000..5102823 Binary files /dev/null and b/docs/img/UpdateRate.png differ diff --git a/docs/img/UpdateRatesScope.png b/docs/img/UpdateRatesScope.png new file mode 100644 index 0000000..cdfe6fd Binary files /dev/null and b/docs/img/UpdateRatesScope.png differ diff --git a/src/MidiThing.cpp b/src/MidiThing.cpp index d763fcd..18340b5 100644 --- a/src/MidiThing.cpp +++ b/src/MidiThing.cpp @@ -295,7 +295,6 @@ struct MidiThing : Module { midi::Message msg; uint8_t outData[32] = {}; while (inputQueue.tryPop(&msg, args.frame)) { - // DEBUG("msg (size: %d): %s", msg.getSize(), msg.toString().c_str()); uint8_t outLen = decodeSysEx(&msg.bytes[0], outData, msg.bytes.size(), false); if (outLen > 3) { @@ -305,7 +304,6 @@ struct MidiThing : Module { if (channel >= 0 && channel < NUM_INPUTS) { if (outData[outLen - 1] < LASTPORTMODE) { portModes[channel] = (PORTMODE_t) outData[outLen - 1]; - // DEBUG("Channel %d, %d: mode %d (%s)", outData[2], channel, portModes[channel], cfgPortModeNames[portModes[channel]]); } } }