Skip to content
This repository has been archived by the owner on Oct 17, 2023. It is now read-only.

Error sending signature request #122

Open
7200rpm opened this issue May 8, 2021 · 2 comments
Open

Error sending signature request #122

7200rpm opened this issue May 8, 2021 · 2 comments
Labels
legacy Related to legacy, non-OpenAPI SDK

Comments

@7200rpm
Copy link

7200rpm commented May 8, 2021

I"m trying to send a signature request with the SDK and hitting an errors. I took the code directly from the getting started section:

client = HelloSign::Client.new api_key: 'API_KEY'
    client.send_signature_request(
      test_mode: 1,
      title: 'NDA with Acme Co.',
      subject: 'The NDA we talked about',
      message: 'Please sign this NDA and then we can discuss more.',
      signers: [
        {
          email_address: '[email protected]',
          name: 'Joe Brown'
        }
      ],
      files: ['NDA.pdf', 'AppendixA.pdf']
    )

Throws a ArgumentError (wrong number of arguments (given 1, expected 2..3))

Also, it's strange that the send signature request isn't documented on the wiki and only documented on the website. Am I doing something wrong?

@jonahgolden
Copy link

+1 for this, I'm hitting the same issue. Any resolution?

@ConorFischer
Copy link

ConorFischer commented Oct 15, 2021

Ran into this today. In my case, it was a bug when passing the :files options. Looks like there hasn't been a gem release within 2 years.

I could suggest pinning a more recent commit. Ruby gems has latest is 3.7.7 and it seems like d47266c would probably resolve the issue. Or at the very least help you figure out what options are wrong / being raised.

Side thought -- These errors feel like they should inherit from StandardError or something other than the base Error, since these errors look to be unrelated to the actual response of the HelloSign api.
https://github.com/HelloFax/hellosign-ruby-sdk/blob/f5b3cb187873d1be7588c6da775012636f8d90a9/lib/hello_sign/error.rb#L90-L94

@jtreminio-dropbox jtreminio-dropbox added the legacy Related to legacy, non-OpenAPI SDK label Mar 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
legacy Related to legacy, non-OpenAPI SDK
Projects
None yet
Development

No branches or pull requests

4 participants