Skip to content
This repository has been archived by the owner on Oct 17, 2023. It is now read-only.

Create a variation of HelloSignException to denote 404s #45

Open
cmpaul opened this issue Feb 25, 2017 · 2 comments
Open

Create a variation of HelloSignException to denote 404s #45

cmpaul opened this issue Feb 25, 2017 · 2 comments
Labels
enhancement legacy Related to legacy, non-OpenAPI SDK

Comments

@cmpaul
Copy link
Contributor

cmpaul commented Feb 25, 2017

Per @mveitas:

It would be nice to introduce a subclass of HelloSignException that might be used to denote a resource that was not found

@cmpaul cmpaul changed the title Create a variation of HelloSignException to denote 404s Create a variation of HelloSignException to denote 404s Feb 25, 2017
@cmpaul cmpaul self-assigned this Feb 27, 2017
@mashley806
Copy link

I 2nd this request. It would be great if HelloSign could throw different exceptions for different events. For example, a couple of weeks ago when AWS was down our end users couldn't sign documents and we were just displaying a generic issue occurred prompt. It would be great if HelloSign could throw a HelloSignMaintenanceException which we could catch and show the user a more friendly meaningful message.

Thanks for your consideration. Matt

@Framinus
Copy link

The following exception is thrown for the error message body when a 409 status code is returned:

Caused by: org.json.JSONException: A JSONObject text must begin with '{' at character 0
at org.json.JSONTokener.syntaxError(JSONTokener.java:410) ~[hellosign-java-sdk-4.0.9-jar-with-dependencies.jar!/:?]
at org.json.JSONObject.(JSONObject.java:179) ~[hellosign-java-sdk-4.0.9-jar-with-dependencies.jar!/:?]
at org.json.JSONObject.(JSONObject.java:402) ~[hellosign-java-sdk-4.0.9-jar-with-dependencies.jar!/:?]
at com.hellosign.sdk.http.HttpClient.asJson(HttpClient.java:206) ~[hellosign-java-sdk-4.0.9-jar-with-dependencies.jar!/:?]
at com.hellosign.sdk.HelloSignClient.createEmbeddedRequest(HelloSignClient.java:797) ~[hellosign-java-sdk-4.0.9-jar-with-dependencies.jar!/:?]

@jtreminio-dropbox jtreminio-dropbox added the legacy Related to legacy, non-OpenAPI SDK label Jun 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement legacy Related to legacy, non-OpenAPI SDK
Projects
None yet
Development

No branches or pull requests

4 participants