Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change speed to km/h or m/s #36

Open
jpmeijers opened this issue Jan 5, 2022 · 0 comments
Open

Change speed to km/h or m/s #36

jpmeijers opened this issue Jan 5, 2022 · 0 comments

Comments

@jpmeijers
Copy link

Currently the Cargo integration requires data in a mix of SI/Metric and Imperial units. Because Helium is being used across the globe, and not only in the US, it would make more sense to use SI units.

The only field that is currently not in SI units is speed.

Changing the expected unit of the speed field would result in a lot of incorrect data being ingested. We therefore need a migration plan. I suggest something like this:

  1. Add new optional fields speed_ms, speed_kph, speed_mph, speed_knots for metre per second, kilometres per hour, miles per hour and knots (as reported in NMEA) respectively.
  2. Stop ingesting the speed field.
  3. (optional) After a couple of months re-enable speed and interpret it as km/h.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant