-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge variables objects when flushing queue #10
Comments
I think that could be useful, but it should be optional, and ideally configurable per debounce key, so one debounce link could debounce requests both with and without merging variables. |
Looks like I don't have permissions to push to the repo? I took a pass at it, curious to get your thoughts. |
Yeah, you'll have to push to your own fork and then open a pull request.
…-------- Original Message --------
On Dec 7, 2019, 3:08 PM, jasimon wrote:
Looks like I don't have permissions to push to the repo? I took a pass at it, curious to get your thoughts.
—
You are receiving this because you commented.
Reply to this email directly, [view it on GitHub](#10?email_source=notifications&email_token=ABSD77FNY2S7I3X652YMOXDQXQUFZA5CNFSM4JVOYXXKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGGRPBY#issuecomment-562894727), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/ABSD77DBURR2H2MBGAVPQMLQXQUFZANCNFSM4JVOYXXA).
|
Sorry for the delay, PR here: #11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Would you be ok with merging the
variables
object for all queued requests when flushing the queue? It seems to me that for cases where you're updating an object instead of a single value that would be the desired behaviour. Happy to take a crack at it if you're open.The text was updated successfully, but these errors were encountered: