Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge variables objects when flushing queue #10

Open
jasimon opened this issue Dec 4, 2019 · 4 comments
Open

Merge variables objects when flushing queue #10

jasimon opened this issue Dec 4, 2019 · 4 comments

Comments

@jasimon
Copy link

jasimon commented Dec 4, 2019

Would you be ok with merging the variables object for all queued requests when flushing the queue? It seems to me that for cases where you're updating an object instead of a single value that would be the desired behaviour. Happy to take a crack at it if you're open.

@helfer
Copy link
Owner

helfer commented Dec 4, 2019

I think that could be useful, but it should be optional, and ideally configurable per debounce key, so one debounce link could debounce requests both with and without merging variables.

@jasimon
Copy link
Author

jasimon commented Dec 7, 2019

Looks like I don't have permissions to push to the repo? I took a pass at it, curious to get your thoughts.

@helfer
Copy link
Owner

helfer commented Dec 10, 2019 via email

@jasimon
Copy link
Author

jasimon commented Jan 10, 2020

Sorry for the delay, PR here: #11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants