Collection of minor changes #26
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…'pytorch_optimizer' instead of official repo for convenience (using the same seed, both implementations give the same loss up to machine precision)
…ree and updated requirements to prevent package conflicts.
spinjo
commented
Nov 19, 2024
spinjo
commented
Nov 19, 2024
…ave no global tokens or no spurions - the previous code crashed in this case
… update in the requirements
…ke tests_regression work without the BaseWrapper (which was removed a long time ago)
…to make them part of the state_dict
… grad norm even if we don't have clip_grad_norm
spinjo
commented
Nov 27, 2024
experiments/base_experiment.py
Outdated
| grad_norm =grad_norm = ( | ||
| torch.nn.utils.clip_grad_norm_( | ||
| self.model.parameters(), | ||
| float('inf'), |
There was a problem hiding this comment.
I think it would be simpler to have something like self.cfg.training.clip_grad_norm if self.cfg.training.clip_grad_norm is not None else float('inf') and avoid the else statement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.