Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hypelinks in SVGs Not Displaying in Github Markdown, But Work in Extension and on Browser #443

Open
Don-Assamongkol1 opened this issue Sep 22, 2024 · 0 comments

Comments

@Don-Assamongkol1
Copy link

Don-Assamongkol1 commented Sep 22, 2024

Hi there!

First, thank you so much for taking the time to create an awesome extension. Diagrams as source code are really nice for manage complexity.

The issue

I'd like to make diagrams as feature-rich as possible in source-code, so I include hyperlinks into them. I create hyperlinks using the extension, but they aren't displayed on Github as clickable hyperlinks.

  • Screenshot showing hyperlinks viewable in the extension:
Screenshot 2024-09-22 at 11 09 26

I'm wondering, is this a known issue with Github not rendering hyperlinks in SVGs? I've searched through older internet archives and it seems that github displaying svgs was a big deal due to potential security threats.

However, I feel that if you are working in an organization, then making hyperlinks clickable doesn't increase the security vulnerability. People can always go to the link directly. Making the UI show that a link is clickable in Github is simply an added convenience.

Now that I'm writing this, I'm not sure if this was the right place to ask, since it's more a Github rendering SVGs issue. But wanted to ask here first to see if anyone using this tool has run into this issue.

Thank you, and have a great day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant