Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecatedFrom shouldn't give a warning for self #814

Closed
VisLab opened this issue Dec 31, 2023 · 2 comments
Closed

deprecatedFrom shouldn't give a warning for self #814

VisLab opened this issue Dec 31, 2023 · 2 comments

Comments

@VisLab
Copy link
Member

VisLab commented Dec 31, 2023

In addition to valid schema values in the deprecatedFrom, the schema validator should not give a warning when the version is itself. Otherwise the prerelease will always give a warning when we add this tag.
@VisLab
Copy link
Member Author

VisLab commented Feb 23, 2024

@IanCa It turns out that the HED specification for deprecatedFrom states:

This element is deprecated. The value of the attribute is the latest schema version in which the element appeared before it was deprecated..

This means that it should give an error when the version is itself. Could you undo the change in a PR and mention this issue?

@IanCa
Copy link
Member

IanCa commented Feb 23, 2024

#869

@IanCa IanCa mentioned this issue Feb 23, 2024
Merged
@IanCa IanCa closed this as completed Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@VisLab @IanCa