Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]Train/Maglev does not give an extension warning #214

Open
VisLab opened this issue Nov 5, 2024 · 0 comments
Open

[BUG]Train/Maglev does not give an extension warning #214

VisLab opened this issue Nov 5, 2024 · 0 comments
Labels
bug Something isn't working tests Issues related to testcases

Comments

@VisLab
Copy link
Member

VisLab commented Nov 5, 2024

  1. parseHedString does not give an extension warning for Train/Maglev. I am not sure where this is checked now, but I think it should be in parseHedString or a function that it calls when we finish the refactoring. I am posting this issue as a reminder. I may add to this issue with other issues that I encounter as I translate the tests.

  2. validating sidecar does not detect missing definitions.

  3. most detection of unit/unit class errors should be done when HED string is originally parsed. It seems to be done much later in the process.

  4. The requireChild implementation seems to be problematic. The parseHedString correctly detects that Duration has requireChild. However event.spec.js is detecting that Label requires a child, which it does not.

  5. Nested definitions do not seem to be detected in bidsValidation

  6. parseHedString should detect the issues in Object/# and Object/Thingie/#. The Object tag cannot have a placeholder.

@VisLab VisLab added bug Something isn't working tests Issues related to testcases labels Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working tests Issues related to testcases
Projects
None yet
Development

No branches or pull requests

1 participant