Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide instructions for offline validation of BIDS datasets #405

Open
yarikoptic opened this issue Oct 2, 2024 · 2 comments
Open

Provide instructions for offline validation of BIDS datasets #405

yarikoptic opened this issue Oct 2, 2024 · 2 comments

Comments

@yarikoptic
Copy link
Contributor

We have a BIDS dataset for which we have LOTS of HED errors and it is a large dataset so it takes long time to run bids-validator. We thought to just run hed validator directly. Got excited to see Javascript and Python versions listed on https://github.com/hed-standard/hed-examples/blob/develop/docs/source/HedValidationGuide.md but then got surprised that there seems to be no way to run hed validator directly locally without "online" or bids-validator. Is it possible? if so -- please add documentation.

Filed

@VisLab
Copy link
Member

VisLab commented Oct 3, 2024

Thanks for the suggestion. I'll make another pass on the docs.

We recommend that users validate the HED in their datasets before doing BIDS validation using the HED python validator. The validation of HED is can really be done independently of the rest of the BIDS and should be done separately. Use the Jupyter notebook validate_bids_dataset.ipynb which can be found in https://github.com/hed-standard/hed-examples/tree/main/src/jupyter_notebooks/bids to do this validation. If something in particular is giving you trouble -- post an issue so we can fix or use as an example in our guide.

The HED python validator has a complete implementation of HED validation. The JavaScript validator is behind -- we are working hard to catch it up --- but it doesn't quite handle validation of the special tags, particularly Delay and Duration yet. If your dataset passes the Python validation -- it should pass the validation in BIDS.

@yarikoptic
Copy link
Contributor Author

yarikoptic commented Oct 3, 2024

notebooks are nice, but IMHO is a wrong level to interface it. Filed

edit: then it would be a matter of adding documentation to fully address this issue ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants