Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One parameter midi messages are misinterpreted #3

Open
pacoandres opened this issue Apr 11, 2020 · 0 comments
Open

One parameter midi messages are misinterpreted #3

pacoandres opened this issue Apr 11, 2020 · 0 comments

Comments

@pacoandres
Copy link

pacoandres commented Apr 11, 2020

Thanks for the project. It's very useful.
I'm using it for making a cheap and simple controller for guitarix, and I've found a bug when sending control messages.

When you send a single parameter message (like Program Change) the host plays it as two messages, one with the correct value and another one with 0 value.

Searching in the USB MIDI specification (https://www.usb.org/document-library/usb-midi-devices-10, page 16) results that the USB MIDI packet should have 32 bits and the first byte should contain the cable number and the message type.

So I've changed line 370 from

midiMsg[iii++] = 0x08;
to
midiMsg[iii++] = (inType>>4);

And everything woks.

Thanks again for the work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant