Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] dubious results for query #478

Open
k4lizen opened this issue Sep 3, 2024 · 2 comments
Open

[BUG] dubious results for query #478

k4lizen opened this issue Sep 3, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@k4lizen
Copy link
Member

k4lizen commented Sep 3, 2024

search query: convert at&t assembly to intel
image
image
The results from hearchco are quite bad, also none of the main google results seem to come up.

@k4lizen k4lizen added the bug Something isn't working label Sep 3, 2024
@aleksasiriski
Copy link
Member

What about when you drop the &? It looks to me as if this is still the same bug on frontend, adding & removes the rest of the query when encoding (before sending the request to agent)

@aleksasiriski aleksasiriski transferred this issue from hearchco/agent Sep 4, 2024
@aleksasiriski
Copy link
Member

Actually, after further testing, I think this is because on agent we do not encode queries:

urll := fmt.Sprintf("%v?q=%v%v", searchURL, query, combinedParams)
anonUrll := fmt.Sprintf("%v?q=%v%v", searchURL, anonymize.String(query), combinedParams)

Will try to fix this with proper URL building and if that fixes it move this issue back to agent. This is an oversight from the very beginning of the project :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants