Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scores with multiple subscores is a bit of a mess #339

Open
turian opened this issue Nov 21, 2021 · 1 comment
Open

scores with multiple subscores is a bit of a mess #339

turian opened this issue Nov 21, 2021 · 1 comment

Comments

@turian
Copy link
Contributor

turian commented Nov 21, 2021 

 def __call__(self, *args, **kwargs) -> Union[Tuple[Tuple[str, float], ...], float]:

is a bit of a mess. We should do this more cleanly and consistently. In fact, we should never have a score that returns a float. It should always return a tuple.
@turian turian mentioned this issue Nov 21, 2021
Merged
@khumairraj
Copy link
Contributor

Sure. This will be more consistent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@turian @khumairraj