Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider changing all <img> to NextJS <Image> #49

Open
mradamcox opened this issue Sep 9, 2024 · 0 comments
Open

Consider changing all <img> to NextJS <Image> #49

mradamcox opened this issue Sep 9, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@mradamcox
Copy link
Contributor

Encountered during the upgrade to NextJS 13.

NextJS has an Image component, which we can use in place of standard img tags.

Pros:

  • Faster/optimized images handled by NextJS
  • No build warnings
  • Pulling code base more in line with all NextJS standards

Cons:

  • These components require a height/width attribute, which we don't necessarily have on the existing image tags. This means it will take a bit of extra effort, and we may need to edit some of the image files to standardize them (not sure though)
  • If future NextJS releases change the Image component, we'll need to update it (presumably, <img> won't be changing any time soon...).
@mradamcox mradamcox added the enhancement New feature or request label Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant