Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in browser.Forms creates nil entries #140

Open
klokare opened this issue Mar 11, 2024 · 0 comments
Open

Bug in browser.Forms creates nil entries #140

klokare opened this issue Mar 11, 2024 · 0 comments

Comments

@klokare
Copy link

klokare commented Mar 11, 2024

I believe there is a subtle bug in browser.Forms. The slice is made with a length instead of a capacity. Here is the original code

// Forms returns an array of every form in the page.
func (bow *Browser) Forms() []Submittable {
	sel := bow.Find("form")
	len := sel.Length()
	if len == 0 {
		return nil
	}

	forms := make([]Submittable, len)
	sel.Each(func(_ int, s *goquery.Selection) {
		forms = append(forms, NewForm(bow, s))
	})
	return forms
}

The make line should be forms := make([]Submittable, 0, len) since we are using append to add items.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant