You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I believe there is a subtle bug in browser.Forms. The slice is made with a length instead of a capacity. Here is the original code
// Forms returns an array of every form in the page.func (bow*Browser) Forms() []Submittable {
sel:=bow.Find("form")
len:=sel.Length()
iflen==0 {
returnnil
}
forms:=make([]Submittable, len)
sel.Each(func(_int, s*goquery.Selection) {
forms=append(forms, NewForm(bow, s))
})
returnforms
}
The make line should be forms := make([]Submittable, 0, len) since we are using append to add items.
The text was updated successfully, but these errors were encountered:
I believe there is a subtle bug in browser.Forms. The slice is made with a length instead of a capacity. Here is the original code
The make line should be
forms := make([]Submittable, 0, len)
since we are using append to add items.The text was updated successfully, but these errors were encountered: