Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Store dimension labels in DatasetBuilder for backends to write #1077

Closed
rly opened this issue Mar 24, 2024 · 0 comments · Fixed by #1081
Closed

[Feature]: Store dimension labels in DatasetBuilder for backends to write #1077

rly opened this issue Mar 24, 2024 · 0 comments · Fixed by #1081
Assignees
Labels
category: enhancement improvements of code or code behavior priority: medium non-critical problem and/or affecting only a small set of users
Milestone

Comments

@rly
Copy link
Contributor

rly commented Mar 24, 2024

What would you like to see added to HDMF?

See hdmf-dev/hdmf-zarr#176 (comment)

On write/build, if a data type has dimension labels specified in the spec, then based on the dimensions of the data, we can infer the dimension labels for the data and store those on the DatasetBuilder. The backend (HDF5IO, ZarrIO) can then write the labels however it chooses.

On read/construct, inferring the dimension labels based on the dimensions of the data and the possible options in the spec is a bit trickier because the IO object creates the builders directly and does not have easy access to the spec for the data type. But maybe this is not needed. In the use case described above, it seems like the NWB Zarr files are being read outside of PyNWB.

Adding full support for dimension labels that link across datasets automatically is a bigger feature that requires changes to the schema language and various schema: #192. The effort could be revived but would take a lot longer than the original need.

What solution would you like?

Do you have any interest in helping implement the feature?

Yes.

@rly rly self-assigned this Mar 24, 2024
@rly rly added category: enhancement improvements of code or code behavior priority: medium non-critical problem and/or affecting only a small set of users labels Mar 24, 2024
@rly rly added this to the Next Release milestone Mar 24, 2024
@rly rly closed this as completed in #1081 Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: enhancement improvements of code or code behavior priority: medium non-critical problem and/or affecting only a small set of users
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant