Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: VectorData with fixed name in spec #1037

Open
oruebel opened this issue Jan 24, 2024 · 0 comments
Open

[Bug]: VectorData with fixed name in spec #1037

oruebel opened this issue Jan 24, 2024 · 0 comments
Assignees
Labels
category: bug errors in the code or code behavior priority: low alternative solution already working and/or relevant to only specific user(s)

Comments

@oruebel
Copy link
Contributor

oruebel commented Jan 24, 2024

What happened?

It is possible to specify VectorData with a fixed name set in the schema. However, DynamicTable.add_column currently does not honor the fixed name and VectorData.__init__ does not do so either. As such, a user is able to create a column with a custom name even if the name is fixed in the schema. This has come up as part the ndx-hed extension.

Steps to Reproduce

See the following unit test on ndx-hed which creates a HedTags column (which has a fixed name HED) using a custom name set to "Blech"

https://github.com/hed-standard/ndx-hed/blob/43113e34aa867b6fa8c20a93e37c2581b0c7fb75/src/pynwb/tests/test_hed_tags.py#L54-L64

Traceback

None

Operating System

macOS

Python Executable

Conda

Python Version

3.12

Package Versions

No response

@oruebel oruebel added category: bug errors in the code or code behavior priority: low alternative solution already working and/or relevant to only specific user(s) labels Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: bug errors in the code or code behavior priority: low alternative solution already working and/or relevant to only specific user(s)
Projects
None yet
Development

No branches or pull requests

1 participant