Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Always consolidate store structure #139

Closed
3 tasks done
CodyCBakerPhD opened this issue Nov 10, 2023 · 3 comments
Closed
3 tasks done

[Feature]: Always consolidate store structure #139

CodyCBakerPhD opened this issue Nov 10, 2023 · 3 comments

Comments

@CodyCBakerPhD
Copy link
Contributor

What would you like to see added to HDMF-ZARR?

From discussion on dandi/dandi-archive#1745 (comment)

Zarr command: https://zarr.readthedocs.io/en/stable/api/convenience.html#zarr.convenience.consolidate_metadata

Always enable consolidation of metadata on NWB file creation to make it easier to traverse store contents and on S3, reduce the number of head-like requests that would be needed to read store structure

Is your feature request related to a problem?

No response

What solution would you like?

Wish the NWBZarrIO or higher level ZarrIO would do this automatically on file creation, but unsure where in the stack to inject that

Do you have any interest in helping implement the feature?

Yes.

Code of Conduct

@oruebel
Copy link
Contributor

oruebel commented Nov 10, 2023

Interesting, I wasn't aware of this feature. The call to create the consolidated metadata I think would need to happen at the end of 'ZarrIO.write_builder' and then 'ZarrIO.open' wound need to check if the consolidated metadata exist to use 'open_consoludated' instead. We'd probably want to also add a 'ZarrIO.consolidate_metadata(..)' function to explicitly update/generate the metadata file and add a flag on write to allow to enable/disable on write.

@oruebel
Copy link
Contributor

oruebel commented Nov 10, 2023

@mavaylon1 do you think you can take a stab at this?

@mavaylon1
Copy link
Contributor

@mavaylon1 do you think you can take a stab at this?

I shall.

@mavaylon1 mavaylon1 mentioned this issue Nov 21, 2023
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants