Bump rules_proto pin #345
Merged
Bump rules_proto pin #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@QuantamHD this change is ready for review! 😄 |
QuantamHD
reviewed
Aug 14, 2024
WORKSPACE
Outdated
Comment on lines
154
to
161
| load("@rules_proto//proto:repositories.bzl", "rules_proto_dependencies") | ||
|
|
||
| rules_proto_dependencies() | ||
|
|
||
| load("@rules_proto//proto:toolchains.bzl", "rules_proto_toolchains") | ||
|
|
||
| rules_proto_toolchains() | ||
|
|
There was a problem hiding this comment.
Can we move these back to the init? Otherwise we'll need to instruct users they'll need a viable proto toolchain instatnitanted in their workspace
QuantamHD
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In rules_proto v6.0.0 a breaking change was introduced that moved a public facing macro. This change updates the version of this repository and accounts for the breaking change.