Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syntax errors #56

Open
hayd opened this issue Jun 2, 2014 · 1 comment
Open

syntax errors #56

hayd opened this issue Jun 2, 2014 · 1 comment

Comments

@hayd
Copy link
Owner

hayd commented Jun 2, 2014

Not sure what should happen with syntax errors, atm files with bad syntax are left unchanged, and no message is shown. Maybe check autopep8._find_logical doesn't raise (SyntaxError, tokenize.TokenError) if verbose?

@hayd hayd added this to the someday milestone Jun 2, 2014
@hayd
Copy link
Owner Author

hayd commented Sep 13, 2014

I guess the question is, what do we want to happen if you are doing this inplace, and one file fails.

Two choices (suppose running inplace):

  1. just let everything work, BUT after fixing then exit(1) and give a message (if verbosity>=1).
  2. raise (before doing any copying) and exit(1) and report failure.

Personally I kinda prefer 1... though 2 is easier. I guess to do 1. you just bookkeep an files_with_syntax_errors list, and print/exit based on that. (There'll be a trivial tweak to the jobs branch.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant