create a separate crate for configuration #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+1
to
+7
| //! Errors that can be thrown when processing configuration. | ||
|
|
||
| /// The errors that can be thrown when processing configuration. | ||
| /// | ||
| /// This is effectively a copy of the `ParseError` enum in the `ndc-sdk` crate. However, we don't | ||
| /// want a dependency on that crate here, as this crate is used by the CLI. Duplicating here and | ||
| /// converting the values later means we can avoid that dependency. |
There was a problem hiding this comment.
Is the ndc-sdk crate introducing the indirect dependency on openssl?
There was a problem hiding this comment.
Yes, ndc-sdk depends on reqwest which in turn depends on openssl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Refactors the configuration code and create a new crate for it that doesn't depend on ndc-sdk directly.
Reason:
ndc-sdkdepends onreqwestcrate which callsopensslwhich in turn creates issue when creating theaarch-linuxCLI binary. There is no need forreqwestwhile creating the configuration for the data connector.Doubts: I'm a little uncertain as to what errors we should be using for the configuration. I'll update the missing URI error in the PR that introduces
reading configuration URI from environment.How