From 7c09e64d86178a1a05bf352935a4a166d1bdeaa1 Mon Sep 17 00:00:00 2001
From: Pranshi <pranshi@hasura.io>
Date: Tue, 30 Apr 2024 14:25:26 +0530
Subject: [PATCH] address review comments

---
 changelog.md          | 2 +-
 crates/cli/src/lib.rs | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/changelog.md b/changelog.md
index 00677bb4..ce1d7751 100644
--- a/changelog.md
+++ b/changelog.md
@@ -12,7 +12,7 @@
 
 - Initial release with support of ndc-spec v0.1.2 (beta)
   - Support for CLI plugin for Hasura v3 CLI, which allows the CLI to 
-    automatically introspect the database on demand.
+    introspect the database on demand.
   - Query explain endpoint has been changed from `/explain` to `/query/explain`.
   - The default port was changed from 8100 to 8080.
 
diff --git a/crates/cli/src/lib.rs b/crates/cli/src/lib.rs
index 0341cf6e..da5f4c3d 100644
--- a/crates/cli/src/lib.rs
+++ b/crates/cli/src/lib.rs
@@ -205,7 +205,7 @@ async fn update_uri_from_context(context: &Context) -> anyhow::Result<()> {
             read_config_file_contents(&configuration_file_path).await?;
         serde_json::from_str(&configuration_file_contents)?
     };
-    if input == ndc_sqlserver::configuration::RawConfiguration::empty() {
+    if input.mssql_connection_string.is_empty() {
         if let Some(uri) = &context.uri {
             input.mssql_connection_string = uri.clone();
         } else {