Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We need tests. #131

Open
zkokaja opened this issue Dec 23, 2022 · 2 comments
Open

We need tests. #131

zkokaja opened this issue Dec 23, 2022 · 2 comments
Assignees

Comments

@zkokaja
Copy link
Contributor

zkokaja commented Dec 23, 2022

We are updating the code a lot, it would be great to have even just really simple tests to run to ensure nothing breaks. Let's brainstorm some ideas, and what to apply it to: podcast, 247, glove, just one conversation? How do we evaluate success?

@zkokaja
Copy link
Contributor Author

zkokaja commented Jan 5, 2023

all this should be automated in a Makefile target:

what are we testing:

  • generate glove, and gpt2
  • one subject, 625
  • two big conversations
  • result: base and embedding pickles

encoding:

  • run encoding for 5 good electrodes glove/gpt2 and plot
  • result: average encoding

create a standard for what we will compare against in the future, but first we need to ensure current code replicates previous results for all electrodes and conversations.

hacky way to manage results folders:

mv results results-old
mkdir results
DO TEST
mv results results-test
mv results-old results

consider using another Makefile or config options

@zkokaja
Copy link
Contributor Author

zkokaja commented Jan 5, 2023

Use just 1024 tokens from each conversation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants