Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move input generation and inference for each class of models into distinct modules #122

Open
hvgazula opened this issue Dec 19, 2022 · 5 comments
Assignees

Comments

@hvgazula
Copy link
Collaborator

hvgazula commented Dec 19, 2022

The input generation, inference, and embeddings/logits extraction functions (as appropriate) tfsemb_main.py should be moved into separate scripts for causal, mlm, and seq2seq models.

@zkokaja
Copy link
Contributor

zkokaja commented Dec 22, 2022

Yes, let's flesh this out and implement a prototype for causal so we can implement it for other types as well.

@zkokaja
Copy link
Contributor

zkokaja commented Dec 22, 2022

Consider adding special tokens to causal models at the beginning, to stay true to what the model was trained on. Needs investigating.

@hvgazula
Copy link
Collaborator Author

@zkokaja
Copy link
Contributor

zkokaja commented Jan 19, 2023

Let's talk about this again

@zkokaja zkokaja reopened this Jan 19, 2023
@zkokaja zkokaja pinned this issue Jan 19, 2023
@zkokaja
Copy link
Contributor

zkokaja commented Jan 26, 2023

waiting to resolve issue with whisper embedding generation replication

@VeritasJoker VeritasJoker unpinned this issue Jan 31, 2023
@zkokaja zkokaja pinned this issue Feb 2, 2023
@hvgazula hvgazula unpinned this issue Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants