Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "colon specifier is experimental feature (issue #5660)" for 3.8 #6801

Closed
phadej opened this issue May 14, 2020 · 4 comments · Fixed by #8089
Closed

Remove "colon specifier is experimental feature (issue #5660)" for 3.8 #6801

phadej opened this issue May 14, 2020 · 4 comments · Fixed by #8089
Assignees
@phadej
Milestone
Considered for 3.8

Comments

@phadej
Copy link
Collaborator

phadej commented May 14, 2020 •
edited
Loading

Blocked on #5660
@phadej phadej added this to the 3.4.0.0 milestone May 14, 2020
@phadej phadej self-assigned this May 14, 2020
@phadej phadej changed the title Remove colon is experimental feature for 3.4 Remove "colon is experimental feature" for 3.4 May 14, 2020
@phadej
Copy link
Collaborator Author

phadej commented Jul 9, 2020

Re-milestoning this for 3.6, as it's blocked on #5660.

@phadej phadej changed the title Remove "colon is experimental feature" for 3.4 Remove "colon is experimental feature" for 3.6 Jul 16, 2020
@gbaz
Copy link
Collaborator

gbaz commented Sep 2, 2021

What even is this about? :-)

@jneira
Copy link
Member

jneira commented Sep 2, 2021

cabal/Cabal/src/Distribution/Types/Mixin.hs

Line 66 in 00a2351

parsecWarning PWTExperimental "colon specifier is experimental feature (issue #5660)"

cabal/Cabal/src/Distribution/Types/Dependency.hs

Line 144 in 00a2351

parsecWarning PWTExperimental "colon specifier is experimental feature (issue #5660)"

???

@jneira jneira changed the title Remove "colon is experimental feature" for 3.6 Remove "colon specifier is experimental feature (issue #5660)" for 3.6 Sep 2, 2021
@fgaz
Copy link
Member

fgaz commented Sep 13, 2021 •
edited
Loading

It's the build-depends: pkg:lib (dependency on sublibrary) syntax, which is still marked as experimental due to #7270

@Mikolaj Mikolaj changed the title Remove "colon specifier is experimental feature (issue #5660)" for 3.6 Remove "colon specifier is experimental feature (issue #5660)" for 3.8 Sep 13, 2021
@fgaz fgaz mentioned this issue May 2, 2022
Merged
8 tasks
fgaz added a commit to fgaz/cabal that referenced this issue May 2, 2022
@fgaz
Remove "colon specifier is experimental feature"
0cdca20 
Same for "visibility is experimental feature"

With haskell#7270 fixed, it's time to allow hackage uploads

Closes haskell#6801
fgaz added a commit to fgaz/cabal that referenced this issue May 4, 2022
@fgaz
Remove "colon specifier is experimental feature"
50eb285 
Same for "visibility is experimental feature"
With haskell#7270 fixed, it's time to allow hackage uploads.

PWTExperimental is not used anymore, but for now I'm keeping it in case
we add other experimental features in the future, so we don't keep
removing and adding it (pushing CPP on users).

Since it isn't used though there is no way to run
cabal-testsuite/PackageTests/DuplicateExperimental/cabal.project
so I'm just removing that test.

Closes haskell#6801
fgaz added a commit to fgaz/cabal that referenced this issue May 4, 2022
@fgaz
Remove "colon specifier is experimental feature"
670d0f9 
Same for "visibility is experimental feature"
With haskell#7270 fixed, it's time to allow hackage uploads.

PWTExperimental is not used anymore, but for now I'm keeping it in case
we add other experimental features in the future, so we don't keep
removing and adding it (pushing CPP on users).

Since it isn't used though there is no way to run
cabal-testsuite/PackageTests/DuplicateExperimental
so I'm just removing that test.

Closes haskell#6801
fgaz added a commit to fgaz/cabal that referenced this issue May 5, 2022
@fgaz
Remove "colon specifier is experimental feature"
ee4a92d 
Same for "visibility is experimental feature"
With haskell#7270 fixed, it's time to allow hackage uploads.

PWTExperimental is not used anymore, but for now I'm keeping it in case
we add other experimental features in the future, so we don't keep
removing and adding it (pushing CPP on users).

Since it isn't used though there is no way to run
cabal-testsuite/PackageTests/DuplicateExperimental
so I'm just removing that test.

Closes haskell#6801
@gbaz gbaz mentioned this issue Jun 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phadej phadej

Labels
None yet
Projects
None yet
Milestone
Considered for 3.8
Development

Successfully merging a pull request may close this issue.

Look up sublibraries also with nonexact deps fgaz/cabal
4 participants
@phadej @jneira @gbaz @fgaz