-
-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split up HasServer, HasClient #1731
Comments
the down side i guess is that the constraints will say |
or we could drop |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
For unit-testing, we need
HasClient
instance that gives usclientWithRoute
, but the instance does not require aRunClient
instance.The easy solution is to write a
RunClient
instance usingundefined
, but it would be nicer to keep separate things separate:... and then require
RunClient
where necessary in order to implement theHasClient'
instance, instead of in the class.Any concerns or objections? If not I may make a PR.
(ping @pcapriotti)
The text was updated successfully, but these errors were encountered: