Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward port path filtering part from #72 #271

Open
sorki opened this issue Nov 30, 2023 · 0 comments
Open

Forward port path filtering part from #72 #271

sorki opened this issue Nov 30, 2023 · 0 comments
Labels
core `hnix-store-core` related nar `hnix-store-nar` related readonly `hnix-store-readonly` related

Comments

@sorki
Copy link
Member

sorki commented Nov 30, 2023

The PR also finishes PathFilter which is now stubbed/abstracted and wrapped in https://github.com/haskell-nix/hnix-store/blob/master/hnix-store-core/src/System/Nix/Store/Types.hs#L16-L18

This requires some -nar changes, the streamNarIO should keep its signature but call a prime version like streamNarIOWithFilter that would also accept PathFilter. The path filter is (un)used in -readonly https://github.com/haskell-nix/hnix-store/blob/master/hnix-store-readonly/src/System/Nix/Store/ReadOnly.hs#L103-L106 and probably should be added to remote as well but that doesn't need to be handled as part of this.

@squalus @vaibhavsagar wanna take a stab at this? If so assign yourself so there's no duplication of work.

I'll tackle the tranformer part of the PR in the meantime.

@sorki sorki added nar `hnix-store-nar` related core `hnix-store-core` related readonly `hnix-store-readonly` related labels Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core `hnix-store-core` related nar `hnix-store-nar` related readonly `hnix-store-readonly` related
Projects
None yet
Development

No branches or pull requests

1 participant