Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix twitter (x) posts for v2 api #827

Merged
merged 8 commits into from
Sep 20, 2024
Merged

Fix twitter (x) posts for v2 api #827

merged 8 commits into from
Sep 20, 2024

Conversation

jackrosa183
Copy link
Contributor

No description provided.

@avogel3
Copy link
Member

avogel3 commented Sep 17, 2024 •
edited
Loading

A few small things to clean up: we should remove the extwitter dependency since we are no longer using it -and- pull/repurpose it's config in config/config.exs. You might be able to adjust it a bit so that you can use it in the oauther_credentials function.

avogel3
avogel3 approved these changes Sep 20, 2024
View reviewed changes
Copy link
Member

@avogel3 avogel3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@avogel3 avogel3 merged commit 66ec669 into master Sep 20, 2024
3 checks passed
@avogel3 avogel3 deleted the twitter-fix branch September 20, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avogel3 avogel3 avogel3 approved these changes

@vnegrisolo vnegrisolo Awaiting requested review from vnegrisolo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jackrosa183 @avogel3