-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 2.34.1 #1914
Merged
Merged
Release 2.34.1 #1914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpogran
force-pushed
the
release_2.34.1
branch
from
December 11, 2024 14:01
813602c
to
5ea6172
Compare
dbanck
reviewed
Dec 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should include some entries from the terraform-ls changelog:
ENHANCEMENTS:
* Stacks: parse terraform-sources.json to support remote component sources ([terraform-ls#1836](https://github.com/hashicorp/terraform-ls/issues/1836))
BUG FIXES:
* Fix incorrect validation for heterogeneous list ([terraform-ls#1884](https://github.com/hashicorp/terraform-ls/issues/1884))
* Fix incorrect validation of references by correctly detecting tuple and object expressions created from for-expressions ([terraform-ls#1890](https://github.com/hashicorp/terraform-ls/issues/1890))
jpogran
force-pushed
the
release_2.34.1
branch
from
December 11, 2024 16:27
5ea6172
to
8c905af
Compare
dbanck
force-pushed
the
release_2.34.1
branch
from
December 11, 2024 17:59
f17d3d0
to
8c905af
Compare
jpogran
force-pushed
the
release_2.34.1
branch
from
December 12, 2024 15:10
8c905af
to
86ef1ee
Compare
dbanck
previously approved these changes
Dec 12, 2024
Co-authored-by: Daniel Banck <[email protected]>
Co-authored-by: Daniel Banck <[email protected]>
dbanck
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.